Fix for amplitude_bell size offset #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeLionX
requested changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 89.99% 90.00% +0.01%
==========================================
Files 53 53
Lines 2088 2091 +3
==========================================
+ Hits 1879 1882 +3
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodeLionX
added
🐛 bug(-fix)
|
Mypy still fails on the test-file. You can add |
CodeLionX
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #49 here is the fix for the amplitude_bell size offset (fixes #49).
I’m not very familiar with unittest TestCase-Classes, @CodeLionX could you please review the
tests/test_generator/test_lengths.py?There might be a more efficient way to check for the valid generation of anomalies under different length values?
Greetings and thanks for the very fast reply.